Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

f/aws_sagemaker_notebook_instance: Volume size #15559

Merged
merged 3 commits into from
Oct 14, 2020
Merged

f/aws_sagemaker_notebook_instance: Volume size #15559

merged 3 commits into from
Oct 14, 2020

Conversation

nikhil-goenka
Copy link
Contributor

@nikhil-goenka nikhil-goenka commented Oct 8, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #15521

Release note for CHANGELOG:

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSSagemakerNotebookInstance_volumesize'
--- PASS: TestAccAWSSagemakerNotebookInstance_volumesize (908.14s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	910.463s
$ make testacc TESTARGS='-run=TestAccAWSSagemakerNotebookInstance_basic'
--- PASS: TestAccAWSSagemakerNotebookInstance_basic (470.15s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	472.978s
...

@nikhil-goenka nikhil-goenka requested a review from a team October 8, 2020 14:23
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/sagemaker Issues and PRs that pertain to the sagemaker service. documentation Introduces or discusses updates to documentation. labels Oct 8, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 8, 2020
@DrFaust92 DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 12, 2020
@DrFaust92
Copy link
Collaborator

Hey @nikhil-goenka, can you add acceptance test for this change?

@ghost ghost added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Oct 12, 2020
@nikhil-goenka
Copy link
Contributor Author

Hey @nikhil-goenka, can you add acceptance test for this change?

added

@DrFaust92
Copy link
Collaborator

DrFaust92 commented Oct 12, 2020 •
edited
Loading

Hey @nikhil-goenka, lets create a separate test for explicit volume argument + update. and check for volume default value in the basic test.

@nikhil-goenka
Copy link
Contributor Author

Hey @nikhil-goenka, lets create a separate test for explicit volume argument + update. and check for volume default value in the basic test.

done

@ghost ghost added size/M Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Oct 12, 2020
@DrFaust92 DrFaust92 self-assigned this Oct 12, 2020
DrFaust92
DrFaust92 approved these changes Oct 12, 2020
View reviewed changes
Copy link
Collaborator

@DrFaust92 DrFaust92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

--- PASS: TestAccAWSSagemakerNotebookInstance_disappears (431.61s)
--- PASS: TestAccAWSSagemakerNotebookInstance_basic (449.75s)
--- PASS: TestAccAWSSagemakerNotebookInstance_volumesize (680.27s)
--- PASS: TestAccAWSSagemakerNotebookInstance_root_access (741.46s)
--- PASS: TestAccAWSSagemakerNotebookInstance_direct_internet_access (805.24s)
--- PASS: TestAccAWSSagemakerNotebookInstance_LifecycleConfigName (382.99s)
--- PASS: TestAccAWSSagemakerNotebookInstance_tags (375.76s)
--- PASS: TestAccAWSSagemakerNotebookInstance_update (702.48s)

@breathingdust
Copy link
Member

LGTM 🚀 Thanks @nikhil-goenka

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws TESTARGS='-run=TestAccAWSSagemakerNotebookInstance_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerNotebookInstance_ -timeout 120m
=== RUN   TestAccAWSSagemakerNotebookInstance_basic
=== PAUSE TestAccAWSSagemakerNotebookInstance_basic
=== RUN   TestAccAWSSagemakerNotebookInstance_update
=== PAUSE TestAccAWSSagemakerNotebookInstance_update
=== RUN   TestAccAWSSagemakerNotebookInstance_volumesize
=== PAUSE TestAccAWSSagemakerNotebookInstance_volumesize
=== RUN   TestAccAWSSagemakerNotebookInstance_LifecycleConfigName
=== PAUSE TestAccAWSSagemakerNotebookInstance_LifecycleConfigName
=== RUN   TestAccAWSSagemakerNotebookInstance_tags
=== PAUSE TestAccAWSSagemakerNotebookInstance_tags
=== RUN   TestAccAWSSagemakerNotebookInstance_disappears
=== PAUSE TestAccAWSSagemakerNotebookInstance_disappears
=== RUN   TestAccAWSSagemakerNotebookInstance_root_access
=== PAUSE TestAccAWSSagemakerNotebookInstance_root_access
=== RUN   TestAccAWSSagemakerNotebookInstance_direct_internet_access
=== PAUSE TestAccAWSSagemakerNotebookInstance_direct_internet_access
=== CONT  TestAccAWSSagemakerNotebookInstance_basic
=== CONT  TestAccAWSSagemakerNotebookInstance_disappears
=== CONT  TestAccAWSSagemakerNotebookInstance_root_access
=== CONT  TestAccAWSSagemakerNotebookInstance_direct_internet_access
=== CONT  TestAccAWSSagemakerNotebookInstance_LifecycleConfigName
=== CONT  TestAccAWSSagemakerNotebookInstance_tags
=== CONT  TestAccAWSSagemakerNotebookInstance_update
=== CONT  TestAccAWSSagemakerNotebookInstance_volumesize
=== CONT  TestAccAWSSagemakerNotebookInstance_disappears
    resource_aws_sagemaker_notebook_instance_test.go:254: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSSagemakerNotebookInstance_disappears (304.44s)
--- PASS: TestAccAWSSagemakerNotebookInstance_basic (313.16s)
--- PASS: TestAccAWSSagemakerNotebookInstance_LifecycleConfigName (366.77s)
--- PASS: TestAccAWSSagemakerNotebookInstance_tags (376.76s)
--- PASS: TestAccAWSSagemakerNotebookInstance_direct_internet_access (635.02s)
--- PASS: TestAccAWSSagemakerNotebookInstance_root_access (655.80s)
--- PASS: TestAccAWSSagemakerNotebookInstance_update (658.29s)
--- PASS: TestAccAWSSagemakerNotebookInstance_volumesize (697.01s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	698.483s

Verified Acceptance Tests in GovCloud (us-gov-west-1)

make testacc TEST=./aws TESTARGS='-run=TestAccAWSSagemakerNotebookInstance_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerNotebookInstance_ -timeout 120m
=== RUN   TestAccAWSSagemakerNotebookInstance_basic
=== PAUSE TestAccAWSSagemakerNotebookInstance_basic
=== RUN   TestAccAWSSagemakerNotebookInstance_update
=== PAUSE TestAccAWSSagemakerNotebookInstance_update
=== RUN   TestAccAWSSagemakerNotebookInstance_volumesize
=== PAUSE TestAccAWSSagemakerNotebookInstance_volumesize
=== RUN   TestAccAWSSagemakerNotebookInstance_LifecycleConfigName
=== PAUSE TestAccAWSSagemakerNotebookInstance_LifecycleConfigName
=== RUN   TestAccAWSSagemakerNotebookInstance_tags
=== PAUSE TestAccAWSSagemakerNotebookInstance_tags
=== RUN   TestAccAWSSagemakerNotebookInstance_disappears
=== PAUSE TestAccAWSSagemakerNotebookInstance_disappears
=== RUN   TestAccAWSSagemakerNotebookInstance_root_access
=== PAUSE TestAccAWSSagemakerNotebookInstance_root_access
=== RUN   TestAccAWSSagemakerNotebookInstance_direct_internet_access
=== PAUSE TestAccAWSSagemakerNotebookInstance_direct_internet_access
=== CONT  TestAccAWSSagemakerNotebookInstance_basic
=== CONT  TestAccAWSSagemakerNotebookInstance_disappears
=== CONT  TestAccAWSSagemakerNotebookInstance_direct_internet_access
=== CONT  TestAccAWSSagemakerNotebookInstance_update
=== CONT  TestAccAWSSagemakerNotebookInstance_LifecycleConfigName
=== CONT  TestAccAWSSagemakerNotebookInstance_tags
=== CONT  TestAccAWSSagemakerNotebookInstance_volumesize
=== CONT  TestAccAWSSagemakerNotebookInstance_root_access
=== CONT  TestAccAWSSagemakerNotebookInstance_disappears
    resource_aws_sagemaker_notebook_instance_test.go:254: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSSagemakerNotebookInstance_disappears (339.18s)
--- PASS: TestAccAWSSagemakerNotebookInstance_LifecycleConfigName (340.36s)
--- PASS: TestAccAWSSagemakerNotebookInstance_tags (347.52s)
--- PASS: TestAccAWSSagemakerNotebookInstance_basic (350.14s)
--- PASS: TestAccAWSSagemakerNotebookInstance_volumesize (544.99s)
--- PASS: TestAccAWSSagemakerNotebookInstance_root_access (594.18s)
--- PASS: TestAccAWSSagemakerNotebookInstance_update (647.71s)
--- PASS: TestAccAWSSagemakerNotebookInstance_direct_internet_access (665.55s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	666.884s

@breathingdust breathingdust added this to the v3.11.0 milestone Oct 14, 2020
@breathingdust breathingdust merged commit b02ce15 into hashicorp:master Oct 14, 2020
@ghost
Copy link

ghost commented Oct 15, 2020

This has been released in version 3.11.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@nikhil-goenka nikhil-goenka deleted the f/aws_sagemaker_notebook_instance-volume-size branch October 18, 2020 09:52
@ghost
Copy link

ghost commented Nov 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 13, 2020
@DrFaust92 DrFaust92 removed their assignment Jun 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DrFaust92 DrFaust92 DrFaust92 approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.11.0
Development

Successfully merging this pull request may close these issues.

EBS Size for Resource: aws_sagemaker_notebook_instance
3 participants
@nikhil-goenka @DrFaust92 @breathingdust